build(debian): separate Qt5/Qt6 build configurations for V25/V20 support#106
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom Jan 29, 2026
Merged
build(debian): separate Qt5/Qt6 build configurations for V25/V20 support#106deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
Conversation
Reviewer's GuideAdjusts Debian packaging to introduce a separate Qt5-based build configuration (via debian/control.1) and simplifies the main debian/control to reference or defer to the new configuration for V25/V20 support. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review这段代码是一个 Debian 软件包控制文件（ 以下是从语法逻辑、代码质量、代码性能和代码安全四个方面进行的详细审查和改进建议： 1. 语法逻辑
2. 代码质量
3. 代码性能
4. 代码安全
改进建议
总结： |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- In debian/control.1,
qttools5-dev-toolsappears twice in Build-Depends; consider removing the duplicate entry to keep the dependency list clean. - Adding a separate
debian/control.1file alongsidedebian/controlis unconventional; consider documenting or encoding in the filename how this alternative control file is meant to be used (e.g., qt5-specific) to avoid confusion for future maintainers.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In debian/control.1, `qttools5-dev-tools` appears twice in Build-Depends; consider removing the duplicate entry to keep the dependency list clean.
- Adding a separate `debian/control.1` file alongside `debian/control` is unconventional; consider documenting or encoding in the filename how this alternative control file is meant to be used (e.g., qt5-specific) to avoid confusion for future maintainers.
## Individual Comments
### Comment 1
<location> `debian/control.1:37-39` </location>
<code_context>
syslinux-common [linux-amd64 linux-i386], genisoimage,
- dde-qt6integration | dde-qt5integration
+ dde-qt6integration
Description: Simple tool for user to create a boot usb stick quickly and easily
It's designed to support deepin system iso, it can works for Debian and ubuntu
iso too.
</code_context>
<issue_to_address>
**nitpick (typo):** Tighten up wording/grammar in the package Description.
The description has a few small grammar issues (e.g., “for user” → “for users”, “it can works” → “it can work”). Consider rephrasing to: `Simple tool for users to create a boot USB stick quickly and easily. It is designed to support deepin system ISOs and also works for Debian and Ubuntu ISOs.`
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+37
to
+39
| Description: Simple tool for user to create a boot usb stick quickly and easily | ||
| It's designed to support deepin system iso, it can works for Debian and ubuntu | ||
| iso too. |
There was a problem hiding this comment.
nitpick (typo): Tighten up wording/grammar in the package Description.
The description has a few small grammar issues (e.g., “for user” → “for users”, “it can works” → “it can work”). Consider rephrasing to: Simple tool for users to create a boot USB stick quickly and easily. It is designed to support deepin system ISOs and also works for Debian and Ubuntu ISOs.
lzwind
approved these changes
Jan 29, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LiHua000, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
Contributor
|
This pr force merged! (status: unstable) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: as title
Summary by Sourcery
Build: